[core-api][experimental] custom_path_fs_io_manager
#26679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_report_runless_asset_event_
branch
from
ff4f756 to
279e003
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
46d632d to
b0d4528
Compare
|
This is the old resource pattern tho. should we mark it deprecated instead? it's successor is |
yuhan
previously requested changes
Dec 26, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_report_runless_asset_event_
branch
from
279e003 to
4df6dab
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
b0d4528 to
a0a1358
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_report_runless_asset_event_
branch
from
4df6dab to
eb93ea8
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
a0a1358 to
d6685c8
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_report_runless_asset_event_
to
12-23-_core-api_experimental_definitions.merge_
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
490e571 to
ff38870
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
d6685c8 to
bbb30b2
Compare
|
updated to superseded with a reference to the newer pattern |
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
ff38870 to
e938ec3
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
bbb30b2 to
ffa35ac
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
e938ec3 to
c84b092
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
ffa35ac to
4fc73c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> public
reason: doubt many people are using this, but it has existed for many many years and there is no reason for us to remove support for it
docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog