[core-api][experimental] AMP #26685
Open
[core-api][experimental] AMP #26685
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
1d7933d to
90497f3
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
2e8e63b to
ec805a4
Compare
yuhan
reviewed
Dec 26, 2024
| @whitelist_for_serdes( | ||
| old_fields={"time_window_partition_scope_minutes": 1e-6}, | ||
| serializer=AutoMaterializePolicySerializer, | ||
| ) | ||
| @deprecated(breaking_version="1.10.0") |
There was a problem hiding this comment.
interesting. i thought we'd want to hold the breaking until some time in Q2
There was a problem hiding this comment.
@yuhan realistically we'll probably bump this to 1.11.0 right before the 1.10 release, but we've actually been threatening to break this API since 1.9, so this keeps the deprecation notice of this one in line with the other AMP APIs
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
90497f3 to
0ea96d8
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
ec805a4 to
a553ee1
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
0ea96d8 to
07509f0
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
a553ee1 to
0e35f35
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
07509f0 to
7611d3a
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
0e35f35 to
3c155bd
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
7611d3a to
fdd99dc
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
3c155bd to
28356f7
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
fdd99dc to
8f05c61
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
28356f7 to
c15fc55
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_get_asset_provenance_
branch
from
8f05c61 to
6b1aae6
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
c15fc55 to
cc8f60e
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_get_asset_provenance_
to
12-23-_core-api_experimental_execution_type
OwenKephart
force-pushed
the
12-23-_core-api_experimental_execution_type
branch
from
3a73704 to
717a8bd
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
cc8f60e to
b187ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> deprecated
reason: it's deprecated, these callsites were missed earlier
docs exist: n/a
How I Tested These Changes
Changelog