Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging #2627

Merged
merged 2 commits into from
May 22, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented May 22, 2024

What happens when your PR merges?

- `feat:` - tag `main` as a new minor release

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration

Provide some background on the changes

Following cds-snc/notification-api#2173, we add the new AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s.

$ make diff-staging
> AWS_PINPOINT_DEFAULT_POOL_ID=pool-8885654b47d6466f9aaee14c62494ff2
$ make diff-production
> AWS_PINPOINT_DEFAULT_POOL_ID=

Note that in production (where AWS_PINPOINT_SC_POOL_ID and AWS_PINPOINT_DEFAULT_POOL_ID are not set) we will still fall back to SNS.

Checklist if making changes to Kubernetes:

  • I know how to get kubectl credentials in case it catches on fire

Copy link

github-actions bot commented May 22, 2024

github-arc-ss-staging	github-arc-controller	5       	2024-05-22 16:02:46.611204082 +0000 UTC	deployed	gha-runner-scale-set-0.8.2	0.8.2      

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

Comparing release=karpenter-crd, chart=/tmp/helmfile1668290868/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile1668290868/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=github-arc, chart=charts/gha-runner-scale-set-controller
Comparing release=github-arc-ss-staging, chart=/tmp/helmfile1668290868/github-arc-controller/staging/github-arc-ss-staging/gha-runner-scale-set/0.8.2/gha-runner-scale-set
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress

@sastels sastels marked this pull request as ready for review May 22, 2024 18:41
@sastels sastels requested a review from jimleroyer as a code owner May 22, 2024 18:41
@sastels sastels requested a review from a team May 22, 2024 18:41
@sastels sastels changed the title feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging May 22, 2024
Copy link
Collaborator

@jzbahrai jzbahrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!

Archive:  .previous.env.zip
  inflating: .env
Archive:  .env.zip
  inflating: .env
114a115
> AWS_PINPOINT_DEFAULT_POOL_ID=pool-8885654b47d6466f9aaee14c62494ff2
➜  notification-manifests git:(add-AWS_PINPOINT_DEFAULT_POOL_ID-variable) make diff-production
Archive:  .previous.env.zip
  inflating: .env
Archive:  .env.zip
  inflating: .env
113a114
> AWS_PINPOINT_DEFAULT_POOL_ID=

@sastels sastels merged commit 2d9536e into main May 22, 2024
4 checks passed
@sastels sastels deleted the add-AWS_PINPOINT_DEFAULT_POOL_ID-variable branch May 22, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants