Revert "Revert "feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging"" #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and se…" This reverts commit ff78977.
github-arc-ss-staging github-arc-controller 7 2024-06-03 14:05:38.96370194 +0000 UTC deployed gha-runner-scale-set-0.8.2 0.8.2
ingress nginx 2 2024-02-12 19:08:42.93215444 +0000 UTC deployed nginx-ingress-1.1.2 3.4.2
Comparing release=karpenter-crd, chart=/tmp/helmfile1317974795/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile1317974795/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=github-arc, chart=charts/gha-runner-scale-set-controller
Comparing release=github-arc-ss-staging, chart=/tmp/helmfile1317974795/github-arc-controller/staging/github-arc-ss-staging/gha-runner-scale-set/0.8.2/gha-runner-scale-set
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress |
13 tasks
…AULT_POOL_ID-variable
jimleroyer
approved these changes
May 28, 2024
There was a problem hiding this comment.
Revert of revert should be good once https://github.com/cds-snc/notification-api/pull/2178/files is merged.
sastels
force-pushed
the
revert-2634-revert-2627-add-AWS_PINPOINT_DEFAULT_POOL_ID-variable
branch
from
71ff025 to
c3967bd
Compare
…AULT_POOL_ID-variable
…AULT_POOL_ID-variable
sastels
deleted the
revert-2634-revert-2627-add-AWS_PINPOINT_DEFAULT_POOL_ID-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2634
Use pinpoint by default.
After merging #2627 we found that the fake internal test number caused an error. We fix this in Fix fake callback, so after that PR merges we can turn Pinpoint back on.