Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s and set in staging" #2634

Merged
merged 1 commit into from
May 22, 2024

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented May 22, 2024

Reverts #2627

turning on pinpoint broke the fake callbacks generated when sending to the fake phone number 😞

I'll fix that, then bring this PR back.

Copy link

github-arc-ss-staging	github-arc-controller	5       	2024-05-22 16:02:46.611204082 +0000 UTC	deployed	gha-runner-scale-set-0.8.2	0.8.2      

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

Comparing release=karpenter-crd, chart=/tmp/helmfile3237874584/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile3237874584/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=github-arc, chart=charts/gha-runner-scale-set-controller
Comparing release=github-arc-ss-staging, chart=/tmp/helmfile3237874584/github-arc-controller/staging/github-arc-ss-staging/gha-runner-scale-set/0.8.2/gha-runner-scale-set
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress

@sastels sastels marked this pull request as ready for review May 22, 2024 21:05
@sastels sastels requested a review from jimleroyer as a code owner May 22, 2024 21:05
Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels requested review from jimleroyer and a team May 22, 2024 21:06
@sastels sastels merged commit ff78977 into main May 22, 2024
4 checks passed
@sastels sastels deleted the revert-2627-add-AWS_PINPOINT_DEFAULT_POOL_ID-variable branch May 22, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants