Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add error message for rows_with_combined_variable_content_too_long" #2164

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Revert "Add error message for rows_with_combined_variable_content_too_long" #2164

merged 2 commits into from
Apr 26, 2024

Conversation

jzbahrai
Copy link
Collaborator

Reverts #2160

@whabanks whabanks mentioned this pull request Apr 26, 2024
Merged
5 tasks
@jzbahrai jzbahrai enabled auto-merge (squash) April 26, 2024 14:47
@jzbahrai jzbahrai merged commit 5b29366 into main Apr 26, 2024
4 checks passed
@jzbahrai jzbahrai deleted the revert-2160-fix/sms-content-length-error branch April 26, 2024 14:49
whabanks added a commit that referenced this pull request May 3, 2024
@whabanks
Reinstate "Add error message for rows_with_combined_variable_content_…
123467b 
…too_long" (#2164)"

This reverts commit 5b29366.
@whabanks whabanks mentioned this pull request May 3, 2024
Merged
5 tasks
whabanks added a commit that referenced this pull request May 22, 2024
@whabanks
Reinstate bulk sms limit (#2169)
6919e3c 
* Reinstate "Add error message for rows_with_combined_variable_content_too_long" (#2164)"

This reverts commit 5b29366.

* Reinstate bulk sms limit validation

- Added an additional check to ensure that we only return an 4xx response if the template type is SMS

* Bump utils version

* Refresh lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whabanks whabanks whabanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzbahrai @whabanks