Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #278 which added additional length checks to bulk SMS sends #293

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

whabanks
Copy link
Contributor

@whabanks whabanks commented Apr 26, 2024

Summary | Résumé

Reverts #278
We encountered a couple issues where SMS limit checking that was a part of this PR was applying to bulk emails when it should only be applicable to bulk SMS.

Related Issues | Cartes liées

#292
cds-snc/notification-admin#1822
cds-snc/notification-api#2164

Test instructions | Instructions pour tester la modification

Release Instructions | Instructions pour le déploiement

After this PR, cds-snc/notification-admin#1822 and cds-snc/notification-api#2164 are merged, we need to:

  1. Bump and tag utils.
  2. Bump the utils version in Admin and API.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@whabanks whabanks changed the title Revert PR #278 Revert PR #278 which added additional length checks to bulk SMS sends Apr 26, 2024
@whabanks whabanks merged commit 0146718 into main Apr 26, 2024
4 checks passed
@whabanks whabanks deleted the revert-278-bulk-sms-limits branch April 26, 2024 14:22
whabanks added a commit that referenced this pull request May 3, 2024
@whabanks whabanks mentioned this pull request May 3, 2024
5 tasks
whabanks added a commit that referenced this pull request May 21, 2024
* Reinstate PR #278 which added additional length checks to bulk SMS sends (#293)"

This reverts commit 0146718.

* Reinstate "Exclude content length errors from recipient_error prop (#290)" (#292)"

This reverts commit cd287cf.

* Remove unused parameter

* Fix params

* Bump utils version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants