Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate bulk sms limit #2169

Merged
merged 8 commits into from
May 22, 2024
Merged

Reinstate bulk sms limit #2169

merged 8 commits into from
May 22, 2024

Conversation

whabanks
Copy link
Contributor

@whabanks whabanks commented May 3, 2024

Summary | Résumé

This PR reinstates bulk sms validation code that was reverted in this PR due to issues with the added validation firing on bulk emails as well.

Related Issues | Cartes liées

cds-snc/notification-utils#294
cds-snc/notification-admin#1834

Test instructions | Instructions pour tester la modification

  1. Send a bulk SMS request via the API
  2. Note that an error message indicating the message length is too long, possibly due to custom content.
  3. Note that the error message is accompanied by the affected row number.

Release Instructions | Instructions pour le déploiement

Due to dep bumps in Utils 52.2.3, this dep bump PR needs to be merged before this PR can be released.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

- Added an additional check to ensure that we only return an 4xx response if the template type is SMS
pyproject.toml Outdated Show resolved Hide resolved
@jzbahrai
Copy link
Collaborator

Tested this on both admin and API, looks like it works!
Screenshot 2024-05-22 at 3 34 51 PM

@whabanks whabanks merged commit 6919e3c into main May 22, 2024
4 checks passed
@whabanks whabanks deleted the reinstate-bulk-sms-limit branch May 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants