Release of API version 1.0.0-rc.1 #127
Conversation
Add part for sim-swap-subscriptions
… into release-1.0.0-rc.1
There was a problem hiding this comment.
@fernandopradocabrillo some suggestions ... the main point is that the v0.4.0 was rewritten. But it need to kept unchanged. The new section about sim-swap-subscriptions belongs into the r1.1 section
|
Comments addressed. Thanks @hdamker! |
documentation/API_documentation/API-Readiness-Checklist_SIM-Swap-1.0.0.md
Outdated
Show resolved
Hide resolved
Thanks for the updates. I resolved the addressed and outdated conversations. And added then a few new ones, see above :-) |
|
@fernandopradocabrillo I will do the final review "on behalf of release management" when you changed this from "draft" to "ready for review". |
CHANGELOG.md
Outdated
| ### Changed | ||
| * Make response properties "latestSimChange" and "swapped" required since they will always be returned [Issue 96](https://github.com/camaraproject/SimSwap/issues/96) | ||
| * Update SIM Swap & SIM Swap notification subscription yaml to make the '+' mandatory for phoneNumber by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/100 | ||
| * Add README file to indicate shift to Confluence page by @bigludo7 in https://github.com/camaraproject/SimSwap/pull/101 |
There was a problem hiding this comment.
This line is not really needed within the Changelog.
|
https://github.com/camaraproject/SimSwap/blob/main/code/API_definitions/sim-swap-subscriptions.yaml: |
|
https://github.com/camaraproject/SimSwap/blob/main/code/API_definitions/sim_swap.yaml: |
|
@fernandopradocabrillo please find above the result from the review across files from release management perspective. If the comments are addressed (especially #133), the PR can get the approval from Release Management. |
I think thats all! thanks @hdamker |
|
@camaraproject/sim-swap_maintainers @AxelNennker Would be good if one of you will review and approve before I support @fernandopradocabrillo here with admin rights to merge the PR (@bigludo7 is on vacation). |
|
@fernandopradocabrillo there seem to be no additional comments. Should I merge the PR so that you can create the r1.1? |
@hdamker Yes! thank you |
|
Merging on behalf Codeowners |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Generation of first release-candidate for Sim Swap API
This first release candidate r1.1 contains the definition and documentation of the release-candidate of the Sim Swap API v1.0.0-rc.1.
Which issue(s) this PR fixes:
Fixes #122