-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare sim swap subscriptions in alpha version for the meta release #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
fernandopradocabrillo
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hdamker
reviewed
Jul 27, 2024
hdamker
reviewed
Jul 27, 2024
documentation/API_documentation/API-Readiness-Checklist_sim-swap-subscriptions-0.1.0.alpha1.md
Outdated
Show resolved
Hide resolved
hdamker
reviewed
Jul 27, 2024
documentation/API_documentation/API-Readiness-Checklist_sim-swap-subscriptions-0.1.0.alpha1.md
Outdated
Show resolved
Hide resolved
11 tasks
Co-authored-by: Herbert Damker <[email protected]>
…ap-subscriptions-0.1.0.alpha1.md Co-authored-by: Herbert Damker <[email protected]>
…ap-subscriptions-0.1.0.alpha1.md Co-authored-by: Herbert Damker <[email protected]>
hdamker
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fernandopradocabrillo
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
NOTE: @fernandopradocabrillo I prepare changelog part
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.