Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimSwap r1.1 release review #55

Closed
11 tasks done
tanjadegroot opened this issue Jul 25, 2024 · 4 comments
Closed
11 tasks done

SimSwap r1.1 release review #55

tanjadegroot opened this issue Jul 25, 2024 · 4 comments
Assignees
Labels
review Review of a proposed release (e.g. release PR)

Comments

@tanjadegroot
Copy link
Collaborator

tanjadegroot commented Jul 25, 2024

Release PR or issue to review

camaraproject/SimSwap#127

Review actions

Assign this issue to yourself and follow the below list.
For any review action, review the file(s) in the issue/PR listed above.
Put comments in the above issue or PR if they concern non-changed files/text.
Put a short summary of the main review result here into the review issue.

  • API Definition files (YAML) (check version in info & servers objects)
  • test file(s) availability
  • changelog updated
  • readme updated (enforce correct release number / API version naming)
  • API readiness checklist(s)

Release actions

Assign this issue to yourself or another RM team member and follow the below list.
When done, tick the box in this issue.

  • API release tracker available on wiki
  • Review comments addressed (by Sub Project)
  • Release PR approved (on behalf of Release Management)
  • PR merged (by Sub Project codeowner)
  • Release created within GitHub (by Sub Project codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

Additional comments

@tanjadegroot tanjadegroot added the review Review of a proposed release (e.g. release PR) label Jul 25, 2024
@tanjadegroot tanjadegroot changed the title SimSwap M3 Fall24 release review SimSwap r1.1 release review Jul 25, 2024
@hdamker
Copy link
Collaborator

hdamker commented Jul 27, 2024

camaraproject/SimSwap#129 (for sim-swap-subscriptions v0.1.0-alpha.1) reviewed as requested by @bigludo7 -> minor comments added.

@hdamker hdamker self-assigned this Jul 30, 2024
@hdamker
Copy link
Collaborator

hdamker commented Aug 1, 2024

Main review results (based on main branch and draft PR camaraproject/SimSwap#127):

  • sim-swap.yaml: Authorization and Authentication section in info.description must be updated (opened issue for that)
  • Mandatory test files for sim-swap still in PR (correctly mentioned within the API Readiness Checklist)
  • API Readiness Checklists, CHANGELOG and README.md: only minor comments

@hdamker
Copy link
Collaborator

hdamker commented Aug 12, 2024

Release created and release tracker updated

@hdamker hdamker closed this as completed Aug 12, 2024
@AxelNennker
Copy link

I found a typo in the simswap yaml file
camaraproject/SimSwap#137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Review of a proposed release (e.g. release PR)
Projects
None yet
Development

No branches or pull requests

3 participants