Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] create contact page #7

Merged
merged 3 commits into from
Jan 11, 2024
Merged

[feat] create contact page #7

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
132ab54
create contact page
ccatherinetan Jan 10, 2024
1bbabe3
change a tag font-weight to 700
ccatherinetan Jan 10, 2024
5d14e9a
change div to section
ccatherinetan Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/components/Contact.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<div class="container">
<h4 id="contact">CONTACT US</h4>
<div class="spacer"></div>
<div class="row">
<h3>Any other&nbsp;</h3><h2>questions?</h2>
</div>
<div class="spacer"></div>
<p class="description">We are here to help you! Please check the FAQ first;
If your question is not already answered, you can reach us at
<a class="email" href="mailto:[email protected]">[email protected]</a>.<br>
<br>
Please email <a class="email" href="mailto:[email protected]">[email protected]</a>
if you need a particular accommodation.
Note that requests made less than 24 hours before the event will likely not be accommodated.
</p>
</div>

<style lang="scss">
div.container {
ccatherinetan marked this conversation as resolved.
Show resolved Hide resolved
display: flex;
flex-direction: column;
align-items: center;
text-align: center;
width: 46.5rem;
Copy link
Collaborator

@jinkang-0 jinkang-0 Jan 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove the width style and use the default width: auto. It should take up all available space.
If not, please use width: 100%.

OH it just occurred to me this is not supposed to stretch. Please ignore the above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To account for varying device sizes, it's best to use flexible units like percentages and viewport units (vh, vw, svh, etc). For your question of using _breakpoint.scss, that's often used in media queries to apply different styles when the screen size (specifically the width) is in a certain range, which should be used as a last resort. To see how to write media queries, refer to the code that Sam wrote in his PR or look to existing .scss files in the Navbar/Hero! Additional documentations can be found here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can adjust it to fit smaller screen sizes after the fact!

margin: 0 auto;
}
div.spacer {
height: 1.5rem;
}

div.row {
display: flex;
flex-direction: row;
}

p.description {
font-weight: 400;
}

a.email {
line-height: 150%;
ccatherinetan marked this conversation as resolved.
Show resolved Hide resolved
text-decoration-line: underline; // the underline is too close to the text...
}
</style>
3 changes: 3 additions & 0 deletions src/styles/_global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ h3 {

h4 {
font-family: fonts.$mono;
letter-spacing: 0.8px;
ccatherinetan marked this conversation as resolved.
Show resolved Hide resolved
font-size: 1rem;
font-weight: 400;
}

h5 {
Expand All @@ -57,6 +59,7 @@ span {
a {
color: colors.$link;
text-decoration: none;
font-weight: 700;
}

button {
Expand Down