-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] create contact page #7
Merged
allisonhongberkeley
merged 3 commits into
main
from
catherine/hfi-19-contact-us-section
Jan 11, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <section> | ||
| <h4 id="contact">CONTACT US</h4> | ||
| <div class="spacer"></div> | ||
| <div class="row"> | ||
| <h3>Any other </h3><h2>questions?</h2> | ||
| </div> | ||
| <div class="spacer"></div> | ||
| <p class="description">We are here to help you! Please check the FAQ first; | ||
| If your question is not already answered, you can reach us at | ||
| <a class="email" href="mailto:[email protected]">[email protected]</a>.<br> | ||
| <br> | ||
| Please email <a class="email" href="mailto:[email protected]">[email protected]</a> | ||
| if you need a particular accommodation. | ||
| Note that requests made less than 24 hours before the event will likely not be accommodated. | ||
| </p> | ||
| </section> | ||
|
|
||
| <style lang="scss"> | ||
| section { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| text-align: center; | ||
| width: 46.5rem; | ||
| margin: 0 auto; | ||
| } | ||
| div.spacer { | ||
| height: 1.5rem; | ||
| } | ||
|
|
||
| div.row { | ||
| display: flex; | ||
| flex-direction: row; | ||
| } | ||
|
|
||
| p.description { | ||
| font-weight: 400; | ||
| } | ||
|
|
||
| a.email { | ||
| text-decoration-line: underline; // the underline is too close to the text... | ||
| } | ||
| </style> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove thewidthstyle and use the defaultwidth: auto. It should take up all available space.If not, please use
width: 100%.OH it just occurred to me this is not supposed to stretch. Please ignore the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To account for varying device sizes, it's best to use flexible units like percentages and viewport units (
vh,vw,svh, etc). For your question of using_breakpoint.scss, that's often used in media queries to apply different styles when the screen size (specifically the width) is in a certain range, which should be used as a last resort. To see how to write media queries, refer to the code that Sam wrote in his PR or look to existing.scssfiles in the Navbar/Hero! Additional documentations can be found here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can adjust it to fit smaller screen sizes after the fact!