Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] create contact page #7

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

ccatherinetan
Copy link
Contributor

@ccatherinetan ccatherinetan commented Jan 10, 2024

What's new?

  • created contact page
  • updated p tag in _global.scss (added font-weight: 400; letter-spacing: 0.8px)

Up for Discussion

  • the underline for the links looks wonky (too close), compared to figma (see below)
  • currently, the container div is set to 46.5rem, per the desktop design on figma.
    • not sure how to make it more compatible for diff screen sizes (how are we supposed to use _breakpoints.scss?)

Current:
Screen Shot 2024-01-10 at 1 53 25 PM
Compare to: Figma
Screen Shot 2024-01-10 at 1 57 14 PM

Linear Task

https://linear.app/hack-for-impact-2024/issue/HFI-19/contact-us-section

Copy link
Collaborator

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a few minor suggestions but should be good to go afterwards!

src/styles/_global.scss Show resolved Hide resolved
src/components/Contact.astro Outdated Show resolved Hide resolved
flex-direction: column;
align-items: center;
text-align: center;
width: 46.5rem;
Copy link
Collaborator

@jinkang-0 jinkang-0 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove the width style and use the default width: auto. It should take up all available space.
If not, please use width: 100%.

OH it just occurred to me this is not supposed to stretch. Please ignore the above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To account for varying device sizes, it's best to use flexible units like percentages and viewport units (vh, vw, svh, etc). For your question of using _breakpoint.scss, that's often used in media queries to apply different styles when the screen size (specifically the width) is in a certain range, which should be used as a last resort. To see how to write media queries, refer to the code that Sam wrote in his PR or look to existing .scss files in the Navbar/Hero! Additional documentations can be found here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can adjust it to fit smaller screen sizes after the fact!

Copy link
Collaborator

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!!!

@christophertorres1
Copy link
Contributor

christophertorres1 commented Jan 11, 2024

looks great! just some little font things to get it exactly like in the design file but it's all good

Copy link
Contributor

@allisonhongberkeley allisonhongberkeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccatherinetan add padding between contact and previous section:

Screenshot 2024-01-10 at 9 36 05 PM

@allisonhongberkeley allisonhongberkeley merged commit ff6a3eb into main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants