-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] create contact page #7
[feat] create contact page #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few minor suggestions but should be good to go afterwards!
flex-direction: column; | ||
align-items: center; | ||
text-align: center; | ||
width: 46.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove the width
style and use the default width: auto
. It should take up all available space.
If not, please use width: 100%
.
OH it just occurred to me this is not supposed to stretch. Please ignore the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To account for varying device sizes, it's best to use flexible units like percentages and viewport units (vh
, vw
, svh
, etc). For your question of using _breakpoint.scss
, that's often used in media queries to apply different styles when the screen size (specifically the width) is in a certain range, which should be used as a last resort. To see how to write media queries, refer to the code that Sam wrote in his PR or look to existing .scss
files in the Navbar/Hero! Additional documentations can be found here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can adjust it to fit smaller screen sizes after the fact!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!!!
looks great! just some little font things to get it exactly like in the design file but it's all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccatherinetan add padding between contact and previous section:
What's new?
Up for Discussion
Current:
Compare to: Figma
Linear Task
https://linear.app/hack-for-impact-2024/issue/HFI-19/contact-us-section