Use jest for testing, add some quality-of-life improvements
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several npm packages like `jest`, `eslint`, and `snazzy` (which is used to format `standard` output) rely on a package called `chalk` to format output. For whatever reason, `chalk` doesn't detect that GitHub Actions supports color. This environment variable tells `chalk` (and thus those other packages) that we support color.
- Rename to hw-fargate-api - Add description - Rearrange
- Add `jest` - Configure `jest` to report coverage - Configure `standard` to play nicely with `jest` - Use `snazzy` to format `standard` output - test results had pretty colored output, so we wanted lint results to have pretty colors, too (This makes it easier to skim the results when looking at CI)
This makes it easier to test
Terraform Plan:will create 1 resource:
will update 2 resources:
will replace (delete then create) 1 resource:
|
Check out the results in CI.
This reverts commit 643c248
blakemorgan
approved these changes
Jun 15, 2021
stuft2
approved these changes
Jun 15, 2021
|
Somehow I expected more bikeshedding. |
This was referenced Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm mainly trying to move the conversation from #214 along.
This bakes some opinions into our template. I figure the changes are relatively non-controversial, since they should work for developers outside of OIT. I'm open to bikeshedding.