Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Problem Matchers to add annotations #96

Closed
GaryGSC opened this issue Nov 3, 2020 · 2 comments
Closed

Use Problem Matchers to add annotations #96

GaryGSC opened this issue Nov 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@GaryGSC
Copy link
Member

GaryGSC commented Nov 3, 2020 •
edited
Loading

Use Problem Matchers to add annotations for lint failures (Terraform, JS, possibly others).
@GaryGSC GaryGSC added the enhancement New feature or request label Nov 3, 2020
@GaryGSC
Copy link
Member Author

GaryGSC commented Jun 15, 2021

The need for this was mostly resolved by #230 (in particular, 144756d), which colorized output in CI.

@GaryGSC
Copy link
Member Author

GaryGSC commented Sep 13, 2021

GitHub Advanced Security provides annotations, especially when using the security-and-quality CodeQL queries or other similar scans, that might overlap or duplicate annotations we'd get from linters. Assuming we enable those, the need for problem matchers is reduced even more.

@GaryGSC GaryGSC closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GaryGSC