Merge pull request #230 from byu-oit/opinions

Use `jest` for testing, add some quality-of-life improvements

.github/workflows/ci.yml

@@ -7,6 +7,7 @@ on:
 env:
   node_version: "14.x"
   tf_version: "0.14.7" # must match value in terraform-iac/*/app/main.tf
+  FORCE_COLOR: 3
 
 jobs:
   env:

.github/workflows/deploy.yml

@@ -6,6 +6,7 @@ on:
 env:
   node_version: "14.x"
   tf_version: "0.14.7" # must match value in terraform-iac/*/app/main.tf
+  FORCE_COLOR: 3
 concurrency: ${{ github.ref }}
 jobs:
   env:

.gitignore

@@ -31,6 +31,7 @@ override.tf.json
 # Include tfplan files to ignore the plan output of command: terraform plan -out=tfplan
 # example: *tfplan*
 
+coverage
 node_modules
 .DS_Store
 .idea

src/Dockerfile

@@ -4,9 +4,9 @@ WORKDIR /usr/app
 COPY package*.json ./
 RUN npm ci --production
 
-COPY index.js .
+COPY app.js server.js ./
 
 ENV NODE_ENV='production'
 USER node
 EXPOSE 8080
-CMD [ "node", "index.js" ]
+CMD [ "node", "server.js" ]

src/index.js → src/app.js

@@ -1,3 +1,4 @@
+'use strict'
 const express = require('express')
 const { DynamoDBClient, ScanCommand } = require('@aws-sdk/client-dynamodb')
 const { S3Client, ListObjectsV2Command } = require('@aws-sdk/client-s3')
@@ -35,6 +36,4 @@ app.get('/', async (req, res) => {
   }
 })
 
-app.listen(8080, () => {
-  console.log('listening on port 8080')
-})
+module.exports = app

src/app.test.js

@@ -0,0 +1,10 @@
+'use strict'
+const request = require('supertest')
+const app = require('./app')
+
+describe('GET /health', () => {
+  test('should return 200', async () => {
+    const response = await request(app).get('/health')
+    expect(response.statusCode).toBe(200)
+  })
+})