Refactor streams-bootstrap cleanup jobs as individual HelmApp #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disrupted
changed the title
disrupted
changed the title
disrupted
changed the title
disrupted
added
type/refactor
disrupted
changed the title
disrupted
added
the
breaking-change
sujuka99
added a commit
that referenced
this pull request
Jan 11, 2024
Preceeds #398 --------- Co-authored-by: Salomon Popp <[email protected]>
|
Please document the breaking changes in the migration guide |
disrupted
commented
Jan 11, 2024
| @@ -2,8 +2,10 @@ helm-app.yaml: | |||
| - app-helm-app.yaml | |||
| - repo_config-helm-app.yaml | |||
| kafka-app.yaml: | |||
| - prefix.yaml | |||
There was a problem hiding this comment.
weird that those weren't there before 😛 nobody noticed
sujuka99
approved these changes
Jan 12, 2024
raminqaf
approved these changes
Jan 12, 2024
| @@ -40,6 +40,22 @@ All Helm-specific parts of the built-in [`KubernetesApp`](../core-concepts/compo | |||
| ... | |||
| ``` | |||
|
|
|||
| ## [Create StreamsBootstrap component & refactor cleanup jobs as individual HelmApp](https://github.com/bakdata/kpops/pull/398) | |||
|
|
|||
| Previously the default `KafkaApp` component configured the [streams-bootstrap](https://bakdata.github.io/streams-bootstrap/) Helm Charts. Now, this component is no longer tied to Helm (or Kubernetes). Instead, there is a new `StreamsBootstrap` component that configures the Helm Chart repository for the components that use it, e.g. `StreamsApp` and `ProducerApp`. If you are using non-default values for the Helm Chart repository or version, it has to be updated as shown below. | |||
There was a problem hiding this comment.
What is the point of having KafkaApp then?
There was a problem hiding this comment.
implement the logic related to Kafka, i.e. creation of output topics
disrupted
added a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #397
extracted the cleanup job needed for streams-bootstrap producer and streams apps to its own HelmApp nested inside the parent component
StreamsBootstrapbase