-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor streams-bootstrap cleanup jobs as individual HelmApp #398
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
62bfb03
Refactor workaround for setting Helm app `nameOverride`
disrupted 55089be
Update snapshot assertions
disrupted 8d9bb60
Use consistent naming for app values
disrupted 934e4ed
Rename fixture
disrupted 1c4e313
Refactor
disrupted 2309a7b
Rename
disrupted 7c8ff89
Merge remote-tracking branch 'origin/v3' into refactor/helm-nameoverride
disrupted f67a23f
Refactor streams-bootstrap cleanup
disrupted 0578cb0
Update tests
disrupted 44195e7
Inherit from common streams-bootstrap app
disrupted a2a8418
Remove desc
disrupted 3457d1f
Fix failing hooks
disrupted 6ac39da
Merge remote-tracking branch 'origin/v3' into refactor/streams-bootst…
disrupted a725f03
Cosmetic
disrupted 26ac7f9
Cosmetic
disrupted b193c03
Rename run to clean
disrupted 9d27adc
Fix returned object type
disrupted c517a3b
Add pydocs and todo
disrupted 11dcc1e
Create streams-bootstrap base for all components based on its Helm
disrupted d9786dd
Cleanup KPOps components import
disrupted a49b551
Fix inheritance order of streams-boostrap apps
disrupted 2e2c7ba
Update components hierarchy diagram
disrupted 02c0ef7
Fix docs
disrupted 70cf1f3
Merge branch 'v3' into refactor/streams-bootstrap-cleanup
disrupted 83ac398
Update defaults schema
disrupted 45c58d8
Add docs for streams-bootstrap
disrupted 7c92421
Add docs for streams-bootstrap
disrupted a5b621b
Merge remote-tracking branch 'origin/v3' into refactor/streams-bootst…
disrupted 916c239
Update schema
disrupted e8fc934
Merge remote-tracking branch 'origin/v3' into refactor/streams-bootst…
disrupted 125c20f
Rename variable in test
disrupted 059632e
Cover breaking change in migration guide
disrupted File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird that those weren't there before 😛 nobody noticed