Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Kafka Connector resetter as individual HelmApp #400

Merged
merged 58 commits into from
Jan 16, 2024
Merged

Refactor Kafka Connector resetter as individual HelmApp #400

merged 58 commits into from
Jan 16, 2024

Conversation

disrupted
Copy link
Member

Depends on #398

disrupted added 30 commits January 2, 2024 12:29
@disrupted
Refactor workaround for setting Helm app nameOverride
62bfb03
@disrupted
Update snapshot assertions
55089be
@disrupted
Use consistent naming for app values
8d9bb60
@disrupted
Rename fixture
934e4ed
@disrupted
Refactor
1c4e313
@disrupted
Rename
2309a7b
@disrupted
Merge remote-tracking branch 'origin/v3' into refactor/helm-nameoverride
7c8ff89
@disrupted
Refactor streams-bootstrap cleanup
f67a23f
@disrupted
Update tests
0578cb0
@disrupted
Inherit from common streams-bootstrap app
44195e7
@disrupted
Remove desc
a2a8418
@disrupted
Fix failing hooks
3457d1f
@disrupted
Merge remote-tracking branch 'origin/v3' into refactor/streams-bootst…
6ac39da 
…rap-cleanup
@disrupted
Cosmetic
a725f03
@disrupted
Cosmetic
26ac7f9
@disrupted
Rename run to clean
b193c03
@disrupted
Fix returned object type
9d27adc
@disrupted
Add pydocs and todo
c517a3b
@disrupted
Refactor Kafka Connector resetter into separate HelmApp
10be5f4
@disrupted
Update tests
e5bd0da
@disrupted
Fix resetter instantiation
cb135bd 
`app`, `namespace` attributes
@disrupted
Fix reset & refactor suffix handling
0bb3e6b
@disrupted
Update test
8467027
@disrupted
Update test
10db07d
@disrupted
Refactor test using pytest fixture
6a04113
@disrupted
Update tests
7ad4f27
@disrupted
Create streams-bootstrap base for all components based on its Helm
11dcc1e 
charts
@disrupted
Cleanup KPOps components import
d9786dd
@disrupted
Fix inheritance order of streams-boostrap apps
a49b551
@disrupted
Update components hierarchy diagram
2e2c7ba
@disrupted disrupted added breaking-change Indicates that this PR introduces a breaking change component/pipeline-components Related to pipeline components labels Jan 11, 2024
Base automatically changed from refactor/streams-bootstrap-cleanup to v3 January 15, 2024 08:18
@disrupted disrupted marked this pull request as ready for review January 15, 2024 09:50
raminqaf
raminqaf reviewed Jan 16, 2024
View reviewed changes
tests/components/test_kafka_sink_connector.py Outdated Show resolved Hide resolved
docs/docs/user/migration-guide/v2-v3.md Show resolved Hide resolved
tests/pipeline/resources/defaults.yaml Outdated Show resolved Hide resolved
@disrupted disrupted requested a review from raminqaf January 16, 2024 09:10
@disrupted disrupted merged commit 4b40e66 into v3 Jan 16, 2024
7 checks passed
@disrupted disrupted deleted the refactor/kafka-connector-resetter branch January 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujuka99 sujuka99 sujuka99 approved these changes

@raminqaf raminqaf raminqaf approved these changes

@irux irux Awaiting requested review from irux

Assignees

@disrupted disrupted

Labels
breaking-change Indicates that this PR introduces a breaking change component/pipeline-components Related to pipeline components type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@disrupted @raminqaf @sujuka99