Update cert manager image in the EKS-A bundle with new image #8812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
|
/test eks-anywhere-e2e-presubmit |
sp1999
changed the title
abhay-krishna
requested changes
Sep 24, 2024
sp1999
force-pushed
the
update-cert-manager-bundle
branch
from
0dee81c to
89d0475
Compare
eks-distro-bot
added
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8812 +/- ##
==========================================
+ Coverage 73.56% 73.65% +0.09%
==========================================
Files 578 578
Lines 36610 36610
==========================================
+ Hits 26931 26965 +34
+ Misses 7953 7919 -34
Partials 1726 1726 ☔ View full report in Codecov by Sentry. |
sp1999
force-pushed
the
update-cert-manager-bundle
branch
2 times, most recently
from
7525e56 to
abfa4a1
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sp1999
force-pushed
the
update-cert-manager-bundle
branch
from
abfa4a1 to
62ed435
Compare
sp1999
force-pushed
the
update-cert-manager-bundle
branch
2 times, most recently
from
9c778c2 to
ac0ae1f
Compare
|
/lgtm |
sp1999
force-pushed
the
update-cert-manager-bundle
branch
from
ac0ae1f to
48631d5
Compare
abhay-krishna
approved these changes
Sep 26, 2024
|
/hold |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
cert-manager-ctlimage was replaced withcert-manager-startupapicheckimage in #3790 when cert-manager was bumped to v1.15.3. This PR updates the corresponding field in the EKS-A bundle to match the upstream image.This PR also removes the
crd:trivialVersions=true,preserveUnknownFields=falseCRD options for controller-gen v0.8.0 as we bumped controller-gen from v0.6.1 to v0.8.0 in #8531 and controller-gen v0.7.0 introduced a breaking change in #607 that removed support for legacy v1beta1 CRDs and webhooks.Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.