Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cert manager to v1.15.3 #3790

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 23, 2024

Description of changes

Notable changes in v1.14.0:
The startupapicheck job uses a new OCI image called "startupapicheck", instead of the ctl image. If you run in an environment in which images cannot be pulled, be sure to include the new image.
PR: cert-manager/cert-manager#6549

Notable changes in v1.15.0:
cmctl and kubectl cert-manager have been moved to the https://github.com/cert-manager/cmctl repo and will be versioned separately starting with cmctl v2.0.0
PR: cert-manager/cert-manager#6663

Based on the above breaking changes, this PR updates the cert-manager-ctl image repository with cert-manager-startupapicheck image to match the upstream image and binaries. This will also require add the cert-manager-startupapicheck private ECR repository to the build, packages and artifacts CDK brazil packages. We should also update the corresponding fields in the EKS-A bundle here to match upstream.

Build CDK: https://code.amazon.com/reviews/CR-150562603

Packages CDK: https://code.amazon.com/reviews/CR-150563498

Artifacts CDK: https://code.amazon.com/reviews/CR-151081511

EKS-A Bundle: aws/eks-anywhere#8812

Testing

Ran TestDockerKubernetes130SimpleFlow and TestVSphereKubernetes128To129UbuntuUpgradeFromLatestMinorRelease E2E tests locally using bundles-override with the latest dev bundle updated with the new cert-manager version images and manifest. The tests passed successfully.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2024
@sp1999
Copy link
Member Author

sp1999 commented Sep 23, 2024

/hold
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999
Copy link
Member Author

sp1999 commented Sep 26, 2024

/unhold

@abhay-krishna
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit d3fe132 into aws:main Sep 26, 2024
3 checks passed
@sp1999 sp1999 deleted the bump-cert-manager-to-v1.15.3 branch September 26, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants