-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cert manager to v1.15.3 #3790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Sep 23, 2024
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 24, 2024
/unhold |
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Notable changes in v1.14.0:
The startupapicheck job uses a new OCI image called "startupapicheck", instead of the ctl image. If you run in an environment in which images cannot be pulled, be sure to include the new image.
PR: cert-manager/cert-manager#6549
Notable changes in v1.15.0:
cmctl and kubectl cert-manager have been moved to the https://github.com/cert-manager/cmctl repo and will be versioned separately starting with cmctl v2.0.0
PR: cert-manager/cert-manager#6663
Based on the above breaking changes, this PR updates the
cert-manager-ctl
image repository withcert-manager-startupapicheck
image to match the upstream image and binaries. This will also require add thecert-manager-startupapicheck
private ECR repository to the build, packages and artifacts CDK brazil packages. We should also update the corresponding fields in the EKS-A bundle here to match upstream.Build CDK: https://code.amazon.com/reviews/CR-150562603
Packages CDK: https://code.amazon.com/reviews/CR-150563498
Artifacts CDK: https://code.amazon.com/reviews/CR-151081511
EKS-A Bundle: aws/eks-anywhere#8812
Testing
Ran
TestDockerKubernetes130SimpleFlow
andTestVSphereKubernetes128To129UbuntuUpgradeFromLatestMinorRelease
E2E tests locally using bundles-override with the latest dev bundle updated with the new cert-manager version images and manifest. The tests passed successfully.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.