Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EKS-A components manifest file #8816

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 27, 2024

Description of changes:
Updated the EKS-A components manifest file by running make release-manifests. The file wasn't updated in #8812 after marking the ctl field as deprecated instead of removing it completely.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.65%. Comparing base (47c2381) to head (fc26e91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8816   +/-   ##
=======================================
  Coverage   73.64%   73.65%           
=======================================
  Files         578      578           
  Lines       36610    36610           
=======================================
+ Hits        26963    26965    +2     
+ Misses       7920     7919    -1     
+ Partials     1727     1726    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Sep 27, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rahulbabu95
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit fe2dad6 into aws:main Sep 27, 2024
8 checks passed
@sp1999 sp1999 deleted the update-eksa-components-manifest branch September 27, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants