Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmd ctl repo to match with latest upstream #3624

Closed
wants to merge 1 commit into from

Conversation

rahulbabu95
Copy link
Member

Description of changes:
Upstream cert-manager removed cmd ctl from their repo in their latest release. Consequently upgrader project is failing for this project as it is not able to build the cert-manager image as it still tries to the cmd-ctl.

/codebuild/output/src2067030760/src/git-codecommit.us-west-2.amazonaws.com/v1/repos/aws.eks-anywhere-build-tooling/tools/version-tracker/eks-anywhere-build-tooling/build/lib/go_mod_download.sh: line 29: cd: cert-manager/cmd/ctl: No such file or directory
--

This change refactors the make targets to not include cmd-ctl to match that of the upstream.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rahulbabu95. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2024
@eks-distro-bot
Copy link
Collaborator

@rahulbabu95: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cert-manager-tooling-presubmit 29061a5 link true /test cert-manager-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rahulbabu95
Copy link
Member Author

/hold

@sp1999
Copy link
Member

sp1999 commented Sep 25, 2024

Cert-manager is being bumped to v1.15.3 separately in this PR which removes the cmd ctl repo and adds the startupapicheck repo instead. Hence, closing this PR as it is no longer needed.

@sp1999 sp1999 closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants