feat: make crosswalk decision more aggressive towards the real world's driving #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s driving Signed-off-by: Takayuki Murooka <[email protected]>
kosuke55
approved these changes
Dec 27, 2023
This was referenced Dec 28, 2023
sykwer
pushed a commit
to sykwer/autoware_launch
that referenced
this pull request
Jan 3, 2024
…ystem-launch feat(system_launch): replace system launch Signed-off-by: asana17 <[email protected]>
This was referenced Jan 10, 2024
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
…roved_module true in foa param (autowarefoundation#762) Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards the real world's driving, this PR enables the following feature since the current crosswalk decision is too conservative.
Tests performed
We tested this feature with the real vehicle in Tokyo, and the behavior became much better and natural.
Effects on system behavior
Not too conservative decision making of crosswalk
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.