-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an env variable to enable the new rviz2 theme #1017
Conversation
Please put the installation related things to the https://github.com/autowarefoundation/autoware/tree/main/ansible/roles We don't want to run custom scripts in the CMakeLists files. |
|
This pull request has been automatically marked as stale because it has not had recent activity. |
fb5c3bc
to
fd85658
Compare
fd85658
to
7d024d3
Compare
sorry for the screenshot quality, OS didnt let me screenshot while textbox was selected. new theme adds an underline to the selected text in the textbox, could you remove that? also i think there is a border around it now. but i think it will look good once it becomes gray with the comment above. |
@xmfcx Should be good to re-review after the latest changes on both the ansible qss side and the tier4_state_rviz_plugin |
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
…onfig Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
… launch file, all changes will be moved to ansible playbook/roles This reverts commit 037224b. Signed-off-by: KhalilSelyan <[email protected]>
7d024d3
to
2ba16b9
Compare
This is just an env var for the theme, we can merge it now. It shouldn't be an issue even if the theme is not installed. But I will test by removing qt5ct on my machine, just in case. |
I've confirmed by uninstalling |
Description
Please see:
This just adds the required env var to the launch file to enable the new theme.
Related links
Tests performed
I've confirmed by uninstalling
qt5ct
I was able to run rviz with older theme with this PR enabled.And with this enabled, and
this PR applied, new theme was usable.
Notes for reviewers
Interface changes
None.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.