-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: qt5ct dark mode integration using ansible #4838
Merged
xmfcx
merged 36 commits into
autowarefoundation:main
from
KhalilSelyan:qt5ct-dark-mode-integration-using-ansible
Sep 19, 2024
Merged
feat: qt5ct dark mode integration using ansible #4838
xmfcx
merged 36 commits into
autowarefoundation:main
from
KhalilSelyan:qt5ct-dark-mode-integration-using-ansible
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhalilSelyan
added
the
type:ui-ux
User interface, user experience, graphical user interfaces.
label
Jun 7, 2024
Merged
7 tasks
I think it's a very interesting approach. However, for existing RViz users, it would be a significant UI change. There is also a great need for documentation changes. |
xmfcx
force-pushed
the
qt5ct-dark-mode-integration-using-ansible
branch
2 times, most recently
from
September 3, 2024 14:30
0717c98
to
14ccc9f
Compare
xmfcx
force-pushed
the
qt5ct-dark-mode-integration-using-ansible
branch
from
September 9, 2024 12:19
fa992cb
to
8a15fe3
Compare
xmfcx
force-pushed
the
qt5ct-dark-mode-integration-using-ansible
branch
2 times, most recently
from
September 12, 2024 09:32
d74b312
to
106b068
Compare
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
…ncy to pass pre-commit-ansible ci Signed-off-by: KhalilSelyan <[email protected]>
…e.builtin.synchronize Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
force-pushed
the
qt5ct-dark-mode-integration-using-ansible
branch
from
September 18, 2024 12:10
9a33dae
to
1dbccd0
Compare
Signed-off-by: KhalilSelyan <[email protected]>
xmfcx
approved these changes
Sep 19, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
tag:run-health-check
Run health-check
type:ui-ux
User interface, user experience, graphical user interfaces.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an Ansible role named
qt5ct_setup
for configuring theqt5ct
environment within the Autoware project. The role ensuresqt5ct
is installed, configures necessary settings inqt5ct.conf
, updates QSS file paths, and manages the correct Autoware directory.This functionality was moved from the PR in autoware_launch to ansible scripts
Related links
Tests performed
ansible
folder.qt5ct.conf
file is correctly updated with the new stylesheet path without overwriting existing stylesheets.Notes for reviewers
qt5ct_setup
role dynamically finds the Autoware directory based on the presence of anansible
folder.QT_QPA_PLATFORMTHEME
export line in/etc/X11/Xsession.d
to avoid conflicts with other QT applications.Interface changes
No changes to ROS topics or parameters.
Effects on system behavior
This PR affects the setup and configuration of the QT environment for Autoware by ensuring
qt5ct
is installed and configured with the appropriate settings. It should not affect runtime behavior but ensures a consistent UI experience for QT applications (specifically RViz) used within Autoware.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.