Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qt5ct dark mode integration using ansible #4838

Conversation

KhalilSelyan
Copy link
Contributor

@KhalilSelyan KhalilSelyan commented Jun 7, 2024

Description

This PR introduces an Ansible role named qt5ct_setup for configuring the qt5ct environment within the Autoware project. The role ensures qt5ct is installed, configures necessary settings in qt5ct.conf, updates QSS file paths, and manages the correct Autoware directory.
This functionality was moved from the PR in autoware_launch to ansible scripts

Related links

Tests performed

  • Tested the role to ensure it correctly identifies the Autoware directory containing the ansible folder.
  • Confirmed that the qt5ct.conf file is correctly updated with the new stylesheet path without overwriting existing stylesheets.
  • Ensured the QSS file paths are updated to absolute paths for icons.

Notes for reviewers

  • The qt5ct_setup role dynamically finds the Autoware directory based on the presence of an ansible folder.
  • The role includes tasks to comment out the QT_QPA_PLATFORMTHEME export line in /etc/X11/Xsession.d to avoid conflicts with other QT applications.

Interface changes

No changes to ROS topics or parameters.

Effects on system behavior

This PR affects the setup and configuration of the QT environment for Autoware by ensuring qt5ct is installed and configured with the appropriate settings. It should not affect runtime behavior but ensures a consistent UI experience for QT applications (specifically RViz) used within Autoware.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@KhalilSelyan KhalilSelyan requested a review from xmfcx June 7, 2024 12:07
@KhalilSelyan KhalilSelyan self-assigned this Jun 7, 2024
@KhalilSelyan KhalilSelyan added the type:ui-ux User interface, user experience, graphical user interfaces. label Jun 7, 2024
@youtalk
Copy link
Member

youtalk commented Jun 10, 2024

I think it's a very interesting approach. However, for existing RViz users, it would be a significant UI change. There is also a great need for documentation changes.
Therefore, why not limit this PR to just the dark mode toggle function and leave the shape changes of UI elements to another PR? This way, the size of the PR will be very small and it will be easier to review.

@xmfcx xmfcx added the tag:run-health-check Run health-check label Jul 12, 2024
@xmfcx xmfcx force-pushed the qt5ct-dark-mode-integration-using-ansible branch 2 times, most recently from 0717c98 to 14ccc9f Compare September 3, 2024 14:30
@xmfcx xmfcx removed the tag:run-health-check Run health-check label Sep 3, 2024
@xmfcx xmfcx force-pushed the qt5ct-dark-mode-integration-using-ansible branch from fa992cb to 8a15fe3 Compare September 9, 2024 12:19
@xmfcx xmfcx force-pushed the qt5ct-dark-mode-integration-using-ansible branch 2 times, most recently from d74b312 to 106b068 Compare September 12, 2024 09:32
KhalilSelyan and others added 19 commits September 18, 2024 15:10
Signed-off-by: KhalilSelyan <[email protected]>
…ncy to pass pre-commit-ansible ci

Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx force-pushed the qt5ct-dark-mode-integration-using-ansible branch from 9a33dae to 1dbccd0 Compare September 18, 2024 12:10
@xmfcx xmfcx added the tag:run-health-check Run health-check label Sep 18, 2024
@xmfcx xmfcx marked this pull request as draft September 18, 2024 14:09
@xmfcx xmfcx marked this pull request as ready for review September 19, 2024 12:55
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx enabled auto-merge (squash) September 19, 2024 13:00
@xmfcx xmfcx disabled auto-merge September 19, 2024 13:15
@xmfcx xmfcx merged commit 549a7f8 into autowarefoundation:main Sep 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:ui-ux User interface, user experience, graphical user interfaces.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants