style: update state panel plugin #8846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
xmfcx
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8846 +/- ##
==========================================
- Coverage 28.01% 27.99% -0.03%
==========================================
Files 1319 1319
Lines 98635 98702 +67
Branches 39789 39786 -3
==========================================
- Hits 27631 27628 -3
- Misses 70949 70982 +33
- Partials 55 92 +37
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I will review this along with the following PR: |
xmfcx
force-pushed
the
style/update-state-panel-plugin
branch
from
430f75c to
ca422f5
Compare
|
Could you add pressed state to these buttons as well? |
|
these should also have pressed state |
|
Please apply the hovered colors to the switch |
xmfcx
force-pushed
the
style/update-state-panel-plugin
branch
from
d432432 to
b59e9a9
Compare
10 tasks
xmfcx
force-pushed
the
style/update-state-panel-plugin
branch
2 times, most recently
from
869c03e to
95dff2f
Compare
Signed-off-by: KhalilSelyan <[email protected]>
…ked state bg color Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: KhalilSelyan <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
force-pushed
the
style/update-state-panel-plugin
branch
from
841d2e0 to
3bd34d7
Compare
xmfcx
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some minimal updates to the style to correct the look overall according to the qt5ct PR as well
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.