Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: escape install task if the specific package is held #4585

Merged

Conversation

Naophis
Copy link
Contributor

@Naophis Naophis commented Apr 2, 2024

Description

When a user, who wants to continue operating Autoware on a specific version of "ros-distro-desktop", executes the setup-dev-env.sh with the ROS packages already held, the installation of ROS 2 fails, and all other installation roles , such as fetching the latest ONNX files, are not executed.

This PR changes is escaping the ROS 2 installation process and issuing a warning when it's already held.

Tests performed

  • Before testing, all of ROS packages are held.
    Screenshot from 2024-04-02 15-53-01

  • Result of setup-dev-env.sh. Failed and other roles are not executed.
    Screenshot from 2024-04-02 16-10-59

  1. If ros-humble-desktop is held and other dependencies package is held.
  • install: skipped (OK)
  • warining: output (OK)
    Screenshot from 2024-04-02 15-59-55
  1. If ros-humble-desktop is not held and others is held.
  • install: changed (OK)
  • warining: skipped (OK)
    Screenshot from 2024-04-02 15-59-18

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Naophis <[email protected]>
@Naophis Naophis removed request for xmfcx and mitsudome-r April 2, 2024 08:16
@Naophis Naophis requested review from xmfcx and mitsudome-r April 2, 2024 08:50
@mitsudome-r mitsudome-r merged commit fb51159 into autowarefoundation:main Apr 5, 2024
13 checks passed
@Naophis Naophis deleted the feat/escape_held_pkg_install branch April 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants