Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: making ros2 installation optional in environment setup #4582

Conversation

Owen-Liuyuxuan
Copy link
Contributor

Description

Making ROS2 installation in the environment setup optional.

Expected use case:

  1. Some users have installed or even lock a certain ROS2 version in their local environment before using Autoware. Giving them an option to skip the ROS2 installation makes environment setup easier for all side.
  2. Exposing an argument to skip ROS2 installation for certain docker image building.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Owen-Liuyuxuan Owen-Liuyuxuan force-pushed the optional_ros2_install branch from 771ec4b to 921cd22 Compare April 2, 2024 06:00
Signed-off-by: Yuxuan Liu <[email protected]>
@Owen-Liuyuxuan
Copy link
Contributor Author

Owen-Liuyuxuan commented Apr 2, 2024

#4585 This PR is completing the task we would like to achieve here.

@mitsudome-r
Copy link
Member

@Owen-Liuyuxuan Is this a duplicate work of #4585?

@Owen-Liuyuxuan
Copy link
Contributor Author

Our final target is the same though. So it is OK to close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants