Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: escape install task if the specific package is held #4585

Merged
merged 5 commits into from
Apr 5, 2024
Merged

feat: escape install task if the specific package is held #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3b45d9
feat: escape install task if the specific package is held
Naophis Apr 2, 2024
6adefc1
feat: use FQCN
Naophis Apr 2, 2024
4484d62
feat: Jinja templates should only be at the end of 'name'
Naophis Apr 2, 2024
9b6b6cc
fix: change literal
Naophis Apr 2, 2024
f9207d5
doc: fix typo
Naophis Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ansible/roles/ros2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ This role installs [ROS 2](http://www.ros2.org/) following [this page](https://d

Additional steps may be needed depending on the `rosdistro` you choose.

To prevent the update of the ROS 2 packages, if ros-`distro`-desktop is held, the installation process for the packages will be skipped and output warning.

<!-- TODO: Add these steps to the role if Humble requires. -->

```bash
Expand Down
13 changes: 13 additions & 0 deletions ansible/roles/ros2/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,25 @@
state: present
update_cache: true

- name: Hold check of ros-{{ rosdistro + '-' + ros2_installation_type }}
ansible.builtin.command: apt-mark showhold
register: held_ros_packages
changed_when: false

- name: Install ros-{{ rosdistro + '-' + ros2_installation_type }}
become: true
ansible.builtin.apt:
name: ros-{{ rosdistro }}-{{ ros2_installation_type }}
state: latest
update_cache: true
when: "'ros-' + rosdistro + '-' + ros2_installation_type not in held_ros_packages.stdout"
register: install_result
failed_when: false

- name: Display warning if ROS 2 package is held
ansible.builtin.debug:
msg: ROS package 'ros-{{ rosdistro + '-' + ros2_installation_type }}' is apt-mark hold. Skipping installation.
when: not install_result.changed

- name: Add PATH to .bashrc
ansible.builtin.lineinfile:
Expand Down
Loading