Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_projection_based_fusion): add timekeeper #9632

Merge branch 'main' into mau/perf/image_projection_based_fusion/add_t…

f4c42d4
Select commit
Loading
Failed to load commit list.
Merged

feat(image_projection_based_fusion): add timekeeper #9632

Merge branch 'main' into mau/perf/image_projection_based_fusion/add_t…
f4c42d4
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 13, 2024 in 1m 24s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (7.96 -> 7.95)

  • Declining Code Health: 5 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method node.cpp: RoiClusterFusionNode::fuseOnSingleImage
  • Complex Method fusion_node.cpp: subCallback
  • Complex Method node.cpp: RoiDetectedObjectFusionNode::generateDetectedObjectRoIs
  • Complex Method fusion_node.cpp: roiCallback
  • Complex Method node.cpp: RoiDetectedObjectFusionNode::fuseObjectsOnImage

Annotations

Check warning on line 187 in perception/autoware_image_projection_based_fusion/src/fusion_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

subCallback increases in cyclomatic complexity from 19 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 326 in perception/autoware_image_projection_based_fusion/src/fusion_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

roiCallback increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 209 in perception/autoware_image_projection_based_fusion/src/pointpainting_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

β„Ή Getting worse: Complex Method

PointPaintingFusionNode::preprocess increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 125 in perception/autoware_image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

RoiClusterFusionNode::fuseOnSingleImage increases in cyclomatic complexity from 40 to 41, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 131 in perception/autoware_image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

RoiDetectedObjectFusionNode::generateDetectedObjectRoIs increases in cyclomatic complexity from 20 to 21, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 219 in perception/autoware_image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

RoiDetectedObjectFusionNode::fuseObjectsOnImage increases in cyclomatic complexity from 15 to 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.