Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_projection_based_fusion): add timekeeper #9632

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Dec 12, 2024

Description

This PR will add time keeper feature to image_projection_based_fusion.

This PR must merge with autowarefoundation/autoware_launch#1274

Sample output:

# roi_cluster_fusion
    🌲 Total Processing Time Tree 🌲
    100.00% roiCallback: total 11.86 [ms], avg. 0.00 [ms], run count: 4103

    100.00% subCallback: total 5867.53 [ms], avg. 10.03 [ms], run count: 585
        ├── 0.00% preprocess: total 0.28 [ms], avg. 0.00 [ms], run count: 585
        ├── 86.38% fuseOnSingleImage: total 5068.63 [ms], avg. 1.44 [ms], run count: 3510
        ├── 0.00% postprocess: total 0.00 [ms], avg. 0.00 [ms], run count: 585
        └── 13.61% rest: 798.62 [ms]

# pointpainting_fusion
    🌲 Total Processing Time Tree 🌲
    100.00% roiCallback: total 7920.99 [ms], avg. 1.93 [ms], run count: 4103
        ├── 88.52% postprocess: total 7012.00 [ms], avg. 27.39 [ms], run count: 256
        ├── 11.16% fuseOnSingleImage: total 883.83 [ms], avg. 2.79 [ms], run count: 317
        │   ├── 0.01% publish debug message: total 0.73 [ms], avg. 0.00 [ms], run count: 317
        │   └── 11.15% rest: 883.10 [ms]
        └── 0.32% rest: 25.16 [ms]

    100.00% subCallback: total 24641.75 [ms], avg. 42.19 [ms], run count: 584
        ├── 5.04% preprocess: total 1240.97 [ms], avg. 2.12 [ms], run count: 584
        ├── 55.29% fuseOnSingleImage: total 13625.33 [ms], avg. 4.40 [ms], run count: 3094
        │   ├── 5.42% publish debug message: total 1335.00 [ms], avg. 0.43 [ms], run count: 3094
        │   └── 49.88% rest: 12290.34 [ms]
        ├── 37.80% postprocess: total 9314.53 [ms], avg. 28.31 [ms], run count: 329
        └── 1.87% rest: 460.92 [ms]

# roi_pointcloud_fusion
    🌲 Total Processing Time Tree 🌲
    100.00% roiCallback: total 21.70 [ms], avg. 0.01 [ms], run count: 4103
        ├── 1.20% fuseOnSingleImage: total 0.26 [ms], avg. 0.00 [ms], run count: 130
        ├── 21.63% postprocess: total 4.69 [ms], avg. 0.04 [ms], run count: 129
        └── 77.17% rest: 16.75 [ms]

    100.00% subCallback: total 763.37 [ms], avg. 1.31 [ms], run count: 584
        ├── 0.01% preprocess: total 0.10 [ms], avg. 0.00 [ms], run count: 584
        ├── 90.50% fuseOnSingleImage: total 690.81 [ms], avg. 0.20 [ms], run count: 3375
        ├── 1.96% postprocess: total 14.96 [ms], avg. 0.03 [ms], run count: 456
        └── 7.53% rest: 57.50 [ms]

# roi_detected_object_fusion
    🌲 Total Processing Time Tree 🌲
    100.00% roiCallback: total 12.57 [ms], avg. 0.00 [ms], run count: 4103

    100.00% subCallback: total 1313.67 [ms], avg. 2.25 [ms], run count: 585
        ├── 0.12% preprocess: total 1.61 [ms], avg. 0.00 [ms], run count: 585
        ├── 90.47% fuseOnSingleImage: total 1188.42 [ms], avg. 0.34 [ms], run count: 3510
        │   ├── 0.34% generateDetectedObjectRoIs: total 4.43 [ms], avg. 0.00 [ms], run count: 3510
        │   ├── 0.01% fuseObjectsOnImage: total 0.07 [ms], avg. 0.00 [ms], run count: 3510
        │   └── 90.12% rest: 1183.91 [ms]
        └── 9.41% rest: 123.63 [ms]

# segmentation_pointcloud_fusion
    🌲 Total Processing Time Tree 🌲
    100.00% subCallback: total 1837.04 [ms], avg. 3.15 [ms], run count: 584
        ├── 0.01% preprocess: total 0.17 [ms], avg. 0.00 [ms], run count: 584
        ├── 72.87% fuseOnSingleImage: total 1338.73 [ms], avg. 2.29 [ms], run count: 584
        ├── 18.70% postprocess: total 343.55 [ms], avg. 0.59 [ms], run count: 584
        └── 8.42% rest: 154.60 [ms]

    100.00% roiCallback: total 1.43 [ms], avg. 0.00 [ms], run count: 587

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <[email protected]>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin self-assigned this Dec 13, 2024
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2024
@technolojin
Copy link
Contributor

@a-maumau Can you test the timekeeper for all variant of the nodes and paste the result in the description please?

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 29.56%. Comparing base (86ba21f) to head (f4c42d4).

Files with missing lines Patch % Lines
..._image_projection_based_fusion/src/fusion_node.cpp 0.00% 12 Missing ⚠️
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% 9 Missing ⚠️
...sed_fusion/src/roi_detected_object_fusion/node.cpp 0.00% 8 Missing ⚠️
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% 6 Missing ⚠️
...on_based_fusion/src/roi_pointcloud_fusion/node.cpp 0.00% 6 Missing ⚠️
...fusion/src/segmentation_pointcloud_fusion/node.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9632      +/-   ##
==========================================
- Coverage   29.88%   29.56%   -0.32%     
==========================================
  Files        1440     1441       +1     
  Lines      108347   108417      +70     
  Branches    42467    41463    -1004     
==========================================
- Hits        32376    32050     -326     
- Misses      72730    73258     +528     
+ Partials     3241     3109     -132     
Flag Coverage Δ *Carryforward flag
differential 2.59% <0.00%> (?)
total 29.57% <ø> (-0.31%) ⬇️ Carriedforward from 2127ca8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin self-requested a review December 13, 2024 04:57
@a-maumau
Copy link
Contributor Author

a-maumau commented Dec 13, 2024

@technolojin I add the all node's sample of timekeeper in the top PR comment.

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin
Copy link
Contributor

@badai-nguyen @tzhong518

Can you review this PR?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 496fb5e into autowarefoundation:main Dec 16, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants