-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image_projection_based_fusion): add timekeeper #9632
feat(image_projection_based_fusion): add timekeeper #9632
Conversation
Signed-off-by: a-maumau <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
@a-maumau Can you test the timekeeper for all variant of the nodes and paste the result in the description please? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9632 +/- ##
==========================================
- Coverage 29.88% 29.56% -0.32%
==========================================
Files 1440 1441 +1
Lines 108347 108417 +70
Branches 42467 41463 -1004
==========================================
- Hits 32376 32050 -326
- Misses 72730 73258 +528
+ Partials 3241 3109 -132
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@technolojin I add the all node's sample of timekeeper in the top PR comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR will add time keeper feature to
image_projection_based_fusion
.This PR must merge with autowarefoundation/autoware_launch#1274
Sample output:
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.