Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autoware_glog_compontnt #9586

Conversation

SakodaShintaro
Copy link
Contributor

Description

The same as autowarefoundation/autoware_launch#1260.

Related links

How was this PR tested?

without any

1733476966.5042253 [ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'glog_component' of type 'GlogComponent' in container '/pointcloud_container': Failed to find class with the requested plugin name.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro self-assigned this Dec 6, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 6, 2024
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki sasakisasaki self-requested a review December 6, 2024 10:11
Copy link

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Reason for approval: Same as this my comment 👍

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.58%. Comparing base (0bbdbe1) to head (eae47d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9586      +/-   ##
==========================================
- Coverage   29.60%   29.58%   -0.02%     
==========================================
  Files        1442     1450       +8     
  Lines      108516   108585      +69     
  Branches    41406    41409       +3     
==========================================
  Hits        32122    32122              
- Misses      73268    73337      +69     
  Partials     3126     3126              
Flag Coverage Δ *Carryforward flag
differential 9.79% <ø> (?)
total 29.60% <ø> (ø) Carriedforward from 0bbdbe1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro marked this pull request as ready for review December 6, 2024 10:24
@SakodaShintaro SakodaShintaro merged commit 9c7ec8a into autowarefoundation:main Dec 6, 2024
39 of 46 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/autoware_glog_component branch December 6, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants