feat(goal_planner): disable freespace feature temporarily #9442
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Nov 25, 2024 in 36s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.60 (2.68 -> 3.27)
- Improving Code Health: 12 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
✅ Improving Code Health:
- Complex Method goal_planner_module.cpp: GoalPlannerModule::setDebugData 🔥
- Lines of Code in a Single File goal_planner_module.cpp 🔥
- Overall Code Complexity goal_planner_module.cpp 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::onFreespaceParkingTimer 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::planPullOverAsOutput 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::isStuck 🔥
- Complex Method goal_planner_module.cpp: GoalPlannerModule::canReturnToLaneParking 🔥
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::onFreespaceParkingTimer 🔥
- Complex Conditional goal_planner_module.cpp: GoalPlannerModule::planPullOverAsOutput 🔥
- Bumpy Road Ahead goal_planner_module.cpp: GoalPlannerModule::planPullOverAsOutput 🔥
- Excess Number of Function Arguments goal_planner_module.cpp: GoalPlannerModule::planFreespacePath 🔥
- Excess Number of Function Arguments goal_planner_module.cpp: GoalPlannerModule::isStuck 🔥
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 2034 to 1801, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
GoalPlannerModule::setDebugData decreases in cyclomatic complexity from 25 to 24, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::onFreespaceParkingTimer is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::planPullOverAsOutput is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::isStuck is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
GoalPlannerModule::canReturnToLaneParking is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
GoalPlannerModule::onFreespaceParkingTimer no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
GoalPlannerModule::planPullOverAsOutput no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
GoalPlannerModule::planPullOverAsOutput is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 6.10 to 5.60, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GoalPlannerModule::planFreespacePath is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GoalPlannerModule::isStuck is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Loading