Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): disable freespace feature temporarily #9442

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 25, 2024

Description

Due to too much complicated and buggy thread synchronization mechanism in goal_planner, freespace feature is disable until basic thread safety design is achieved.

Related links

autowarefoundation/autoware_launch#1250

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

Freespace feature is disabled and several related scenarios are disable as well.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin changed the title feat!(goal_planner): disable freespace feature temporarily feat(goal_planner)!: disable freespace feature temporarily Nov 25, 2024
@soblin soblin force-pushed the feat/goal-planner/disable-freespace branch from 1e2d52d to 64ef059 Compare November 25, 2024 05:32
@soblin soblin changed the title feat(goal_planner)!: disable freespace feature temporarily feat(goal_planner): disable freespace feature temporarily Nov 25, 2024
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 25, 2024
@soblin soblin marked this pull request as ready for review November 25, 2024 08:24
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.02%. Comparing base (740d42a) to head (64ef059).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 7 Missing ⚠️
...r_path_goal_planner_module/goal_planner_module.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9442      +/-   ##
==========================================
+ Coverage   29.00%   29.02%   +0.01%     
==========================================
  Files        1427     1432       +5     
  Lines      108199   108140      -59     
  Branches    41386    41309      -77     
==========================================
  Hits        31386    31386              
+ Misses      73776    73713      -63     
- Partials     3037     3041       +4     
Flag Coverage Δ *Carryforward flag
differential 0.53% <0.00%> (?)
total 29.04% <ø> (+0.03%) ⬆️ Carriedforward from 740d42a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@soblin soblin closed this Nov 28, 2024
@soblin soblin deleted the feat/goal-planner/disable-freespace branch December 13, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant