Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_multi_object_tracker): set maximum reverse velocity to bicycle and crtv motion models #9019

Merged
merged 3 commits into from
Oct 4, 2024

refactor: remove config checker in the initializer

29740a4
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_multi_object_tracker): set maximum reverse velocity to bicycle and crtv motion models #9019

refactor: remove config checker in the initializer
29740a4
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Oct 4, 2024 in 51s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.27 (8.82 -> 8.55)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method bicycle_motion_model.cpp: BicycleMotionModel::limitStates
  • Complex Method ctrv_motion_model.cpp: CTRVMotionModel::limitStates

Annotations

Check warning on line 248 in perception/autoware_multi_object_tracker/lib/tracker/motion_model/bicycle_motion_model.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

BicycleMotionModel::limitStates has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 225 in perception/autoware_multi_object_tracker/lib/tracker/motion_model/ctrv_motion_model.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

CTRVMotionModel::limitStates has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis