Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(polar_grid): add autoware prefix to polar_grid #8945

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Sep 24, 2024

Description

Added autoware prefix to polar_grid

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve changed the title chore(polar_grid): add autoware prefix to polar_grid refactor(polar_grid): add autoware prefix to polar_grid Sep 24, 2024
@esteve esteve marked this pull request as ready for review September 24, 2024 08:37
@esteve esteve requested a review from yukkysaito as a code owner September 24, 2024 08:37
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.96%. Comparing base (a71ef19) to head (4362cba).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8945      +/-   ##
==========================================
- Coverage   26.99%   26.96%   -0.04%     
==========================================
  Files        1298     1299       +1     
  Lines       95807    95924     +117     
  Branches    39111    39117       +6     
==========================================
  Hits        25866    25866              
- Misses      67295    67412     +117     
  Partials     2646     2646              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 26.99% <ø> (ø) Carriedforward from a71ef19

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve enabled auto-merge (squash) September 24, 2024 09:15
@esteve
Copy link
Contributor Author

esteve commented Sep 24, 2024

@xmfcx @mitsudome-r @yukkysaito I couldn't find any packages in universe that depend on this package, so I wasn't sure if it'd be best to remove it. But perhaps it has downstream dependencies in other repositories?

@xmfcx
Copy link
Contributor

xmfcx commented Sep 24, 2024

This is used in the default Autoware rviz configuration. Shows the polar grid and the periodic growing circles around the vehicle.

So we would need to update the rviz file in autoware_launch repo as well.

@esteve
Copy link
Contributor Author

esteve commented Oct 14, 2024

@yukkysaito can you please have a look at this PR? Thanks.

@esteve esteve force-pushed the prefix-polar_grid branch from e14175f to 4362cba Compare October 14, 2024 09:55
@esteve
Copy link
Contributor Author

esteve commented Oct 14, 2024

@xmfcx I couldn't find any references to polar_grid in the autoware_launch repository. Can you point me to where I should make the changes? Thanks.

@xmfcx
Copy link
Contributor

xmfcx commented Oct 14, 2024

@esteve

https://github.com/autowarefoundation/autoware_launch/blob/565568d2ea47ad2a0d92d2cb544f27d3b0efc93e/autoware_launch/rviz/autoware.rviz#L233-L246

It is referenced through the plugin class name: rviz_plugins/PolarGridDisplay.

So you probably don't need to update it on the RViz config side.

@esteve
Copy link
Contributor Author

esteve commented Oct 15, 2024

@xmfcx thanks for checking, I only saw references to the classes in autoware_launch, but not the package or the namespace. So all the changes here are self contained and could be merged, right?

@esteve
Copy link
Contributor Author

esteve commented Oct 15, 2024

@yukkysaito could you have a look at these changes when you have a moment? Thanks.

@esteve esteve merged commit 08d4914 into autowarefoundation:main Oct 15, 2024
32 checks passed
@esteve esteve deleted the prefix-polar_grid branch October 15, 2024 11:02
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants