-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(polar_grid): add autoware prefix to polar_grid #8945
Conversation
3270232
to
1b57c04
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
1b57c04
to
e14175f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8945 +/- ##
==========================================
- Coverage 26.99% 26.96% -0.04%
==========================================
Files 1298 1299 +1
Lines 95807 95924 +117
Branches 39111 39117 +6
==========================================
Hits 25866 25866
- Misses 67295 67412 +117
Partials 2646 2646
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@xmfcx @mitsudome-r @yukkysaito I couldn't find any packages in universe that depend on this package, so I wasn't sure if it'd be best to remove it. But perhaps it has downstream dependencies in other repositories? |
This is used in the default Autoware rviz configuration. Shows the polar grid and the periodic growing circles around the vehicle. So we would need to update the rviz file in autoware_launch repo as well. |
@yukkysaito can you please have a look at this PR? Thanks. |
Signed-off-by: Esteve Fernandez <[email protected]>
e14175f
to
4362cba
Compare
@xmfcx I couldn't find any references to |
It is referenced through the plugin class name: So you probably don't need to update it on the RViz config side. |
@xmfcx thanks for checking, I only saw references to the classes in |
@yukkysaito could you have a look at these changes when you have a moment? Thanks. |
…dation#8945) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: prakash-kannaiah <[email protected]>
Description
Added
autoware
prefix topolar_grid
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.