Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pid_longitudinal_controller): fix the same point error #8758

Merged
merged 2 commits into from
Sep 4, 2024

delete null line

68f172f
Select commit
Loading
Failed to load commit list.
Merged

fix(pid_longitudinal_controller): fix the same point error #8758

delete null line
68f172f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 4, 2024 in 39s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (5.82 -> 5.81)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method pid_longitudinal_controller.cpp: PidLongitudinalController::getControlData

Annotations

Check warning on line 511 in control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

PidLongitudinalController::getControlData already has high cyclomatic complexity, and now it increases in Lines of Code from 87 to 89. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis