fix(pid_longitudinal_controller): fix the same point error #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
requested review from
soblin,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yuki-takagi-66
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8758 +/- ##
==========================================
- Coverage 24.11% 24.11% -0.01%
==========================================
Files 1406 1406
Lines 102314 102332 +18
Branches 38818 38822 +4
==========================================
+ Hits 24672 24674 +2
- Misses 75127 75142 +15
- Partials 2515 2516 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Sep 4, 2024
yuki-takagi-66
merged commit 0efb315
into
autowarefoundation:main
40 of 41 checks passed
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2024
…oundation#8758) * fix same point Signed-off-by: Yuki Takagi <[email protected]>
saka1-s
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2024
…oundation#8758) (#1512) * fix same point Signed-off-by: Yuki Takagi <[email protected]>
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 10, 2024
…oundation#8758) * fix same point Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: emuemuJP <[email protected]>
batuhanbeytekin
pushed a commit
to batuhanbeytekin/autoware.universe
that referenced
this pull request
Sep 12, 2024
…oundation#8758) * fix same point Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 17, 2024
…oundation#8758) * fix same point Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 17, 2024
…oundation#8758) * fix same point Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix the same point error related to #4712
Related links
How was this PR tested?
A rosbag that cause the problem fixed by this pr
psim and tier4 internal test
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.