feat(time-based-safe-dist): improve obstacle_cruise_planner safe distance for dence urban ODD scenarios #7987
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jul 15, 2024 in 54s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.01 (6.33 -> 6.32)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method planner_interface.cpp: PlannerInterface::calculateMarginFromObstacleOnCurve
- Complex Method pid_based_planner.cpp: PIDBasedPlanner::calcObstacleToCruise
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PIDBasedPlanner::calcObstacleToCruise increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.10 to 5.20, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 449 in planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PlannerInterface::calculateMarginFromObstacleOnCurve already has high cyclomatic complexity, and now it increases in Lines of Code from 74 to 76. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading