-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_obstacle_stop_planner): rework parameters #7795
refactor(autoware_obstacle_stop_planner): rework parameters #7795
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7795 +/- ##
==========================================
- Coverage 24.01% 23.93% -0.09%
==========================================
Files 1384 1385 +1
Lines 102173 102078 -95
Branches 38947 38891 -56
==========================================
- Hits 24536 24430 -106
- Misses 75138 75172 +34
+ Partials 2499 2476 -23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/adaptive_cruise_control.schema.json
Outdated
Show resolved
Hide resolved
planning/autoware_obstacle_stop_planner/schema/adaptive_cruise_control.schema.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like CI is still failing for json schema check. It seems to be due to syntax error.
planning/autoware_obstacle_stop_planner/schema/obstacle_stop_planner.schema.json
Outdated
Show resolved
Hide resolved
2b64d0c
to
9a47f6f
Compare
planning/autoware_obstacle_stop_planner/schema/adaptive_cruise_control.schema.json
Outdated
Show resolved
Hide resolved
Although there are no approval from the code owner, I will be merging this PR once the CI passes since there weren't any reactions from them for over a week. This PR only affects the documentation and shouldn't affect the behavior of Autoware anyways. |
Signed-off-by: Ariiees <[email protected]>
Signed-off-by: Ariiees <[email protected]>
Signed-off-by: Ariiees <[email protected]>
Signed-off-by: Ariiees <[email protected]>
Signed-off-by: Ariiees <[email protected]>
4cd939f
to
38f866a
Compare
Hi @mitsudome-r, Sure! Thank you so much. I will also keep an eye on this. And make sure it sync with the main. |
…foundation#7795) Signed-off-by: Ariiees <[email protected]>
…foundation#7795) Signed-off-by: Ariiees <[email protected]>
Description
Implement the ROS Node configuration layout for the obstacle_stop_planner package.
Test performed
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_obstacle_stop_planner
ros2 launch autoware_obstacle_stop_planner obstacle_stop_planner.launch.xml
Notes for reviewers
None
Interface Changes
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.