refactor(vehicle_cmd_gate)!: delete rate limit skipping function for vehicle departure #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
7 tasks
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/delete-special-function-for-depature
branch
2 times, most recently
from
6606369 to
ea52b3a
Compare
yuki-takagi-66
changed the title
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/delete-special-function-for-depature
branch
from
ea52b3a to
81c5197
Compare
yuki-takagi-66
changed the title
4 tasks
yuki-takagi-66
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7720 +/- ##
=======================================
Coverage 29.13% 29.14%
=======================================
Files 1610 1614 +4
Lines 118128 118163 +35
Branches 50850 50848 -2
=======================================
+ Hits 34422 34434 +12
- Misses 74499 74525 +26
+ Partials 9207 9204 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TakaHoribe
reviewed
Jul 19, 2024
| steer_lim: [1.0, 1.0, 1.0, 0.8] | ||
| steer_rate_lim: [1.0, 1.0, 1.0, 0.8] | ||
| lon_acc_lim: [5.0, 5.0, 5.0, 4.0] | ||
| lon_jerk_lim: [80.0, 5.0, 5.0, 4.0] |
There was a problem hiding this comment.
Please add some comments here to describe the reasons/backgrounds of this parameter.
There was a problem hiding this comment.
@TakaHoribe
Thank you. I added a brief comments
There was a problem hiding this comment.
@TakaHoribe
I also add some comments to the readme document
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/delete-special-function-for-depature
branch
from
bd2a006 to
544bd64
Compare
github-actions
bot
added
the
type:documentation
TakaHoribe
approved these changes
Jul 19, 2024
| steer_lim: [1.0, 1.0, 1.0, 0.8] | ||
| steer_rate_lim: [1.0, 1.0, 1.0, 0.8] | ||
| lon_acc_lim: [5.0, 5.0, 5.0, 4.0] | ||
| lon_jerk_lim: [80.0, 5.0, 5.0, 4.0] # The first element is required for quick pedal changes when stopping and starting on a slope. |
There was a problem hiding this comment.
This setting is not unique for a slope.
Suggested change
| lon_jerk_lim: [80.0, 5.0, 5.0, 4.0] # The first element is required for quick pedal changes when stopping and starting on a slope. | |
| lon_jerk_lim: [80.0, 5.0, 5.0, 4.0] # The first element is required for quick pedal changes when stopping and starting. |
… the parameter settings. Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/delete-special-function-for-depature
branch
from
823d345 to
745374d
Compare
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
deleted the
vehicle_cmd_gate/delete-special-function-for-depature
branch
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <[email protected]>
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 23, 2024
…vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jul 23, 2024
…vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 24, 2024
…vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <[email protected]>
saka1-s
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 25, 2024
* feat(simple_planning_simulator): add new vehicle model with falling down (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <[email protected]> * refactor(vehicle_cmd_gate)!: delete rate limit skipping function for vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <[email protected]> * feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition (autowarefoundation#7718) change diff limit structure change stopped condition define a new param Signed-off-by: Yuki Takagi <[email protected]> --------- Signed-off-by: Yuki Takagi <[email protected]>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR delete rate limit skipping function which is activated when the vehicle departure.
More appropriate feature, including stopping, can be achieved by the parameter settings.
Related links
autowarefoundation/autoware_launch#1077
How was this PR tested?
I have tested this change by two type of real vehicles.
Notes for reviewers
None.
Effects on system behavior
None.