-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid_longitudinal_controller): re-organize diff limit structure #1052
Merged
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:pid_long-fix-diff-limit-structure
Jul 24, 2024
Merged
feat(pid_longitudinal_controller): re-organize diff limit structure #1052
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:pid_long-fix-diff-limit-structure
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:system
System design and integration. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
labels
Jul 4, 2024
yuki-takagi-66
changed the title
Pid long fix diff limit structure
feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition
Jul 4, 2024
yuki-takagi-66
changed the title
feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition
feat(pid_longitudinal_controller): re-organize diff limit structure
Jul 4, 2024
yuki-takagi-66
force-pushed
the
pid_long-fix-diff-limit-structure
branch
2 times, most recently
from
July 19, 2024 10:24
a0bb4d5
to
f9405be
Compare
github-actions
bot
removed
component:system
System design and integration. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
labels
Jul 19, 2024
yuki-takagi-66
requested review from
takayuki5168,
rej55,
satoshi-ota,
shmpwk,
danielsanchezaran,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori,
kosuke55,
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
July 19, 2024 10:31
yuki-takagi-66
force-pushed
the
pid_long-fix-diff-limit-structure
branch
from
July 22, 2024 05:07
f9405be
to
aee38c7
Compare
yuki-takagi-66
requested review from
ito-san,
isamu-takagi and
tkimura4
as code owners
July 22, 2024 05:07
github-actions
bot
added
component:system
System design and integration. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
labels
Jul 22, 2024
yuki-takagi-66
force-pushed
the
pid_long-fix-diff-limit-structure
branch
from
July 22, 2024 05:24
aee38c7
to
6353631
Compare
yuki-takagi-66
force-pushed
the
pid_long-fix-diff-limit-structure
branch
from
July 23, 2024 04:11
6353631
to
dcbb8d7
Compare
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
pid_long-fix-diff-limit-structure
branch
from
July 24, 2024 02:28
b0344bb
to
75f28ba
Compare
github-actions
bot
removed
component:system
System design and integration. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
labels
Jul 24, 2024
takayuki5168
approved these changes
Jul 24, 2024
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 15, 2024
…utowarefoundation#1052) * rearange params Signed-off-by: Yuki Takagi <[email protected]>
Merged
4 tasks
rej55
added a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 15, 2024
feat(pid_longitudinal_controller): re-organize diff limit structure autowarefoundation#1052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
launch side PR corresponds to a universe PR autowarefoundation/autoware.universe#7720
Tests performed
see universe PR
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.