feat(ekf_localizer): add covariance ellipse diagnostics #7708
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jun 27, 2024 in 39s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication diagnostics.cpp
- Primitive Obsession diagnostics.cpp
Annotations
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: check_measurement_delay_gate,check_measurement_mahalanobis_gate. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Primitive Obsession
In this module, 75.0% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Loading