fix(lidar_centerpoint): fix constexpr related bugs #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryuta Kambe <[email protected]>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
veqcc
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7686 +/- ##
==========================================
- Coverage 14.84% 2.63% -12.21%
==========================================
Files 1999 165 -1834
Lines 139163 10118 -129045
Branches 43716 1579 -42137
==========================================
- Hits 20661 267 -20394
+ Misses 95731 9761 -85970
+ Partials 22771 90 -22681
☔ View full report in Codecov by Sentry. |
knzo25
approved these changes
Jun 25, 2024
|
@knzo25 |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…n#7686) Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…n#7686) Signed-off-by: Ryuta Kambe <[email protected]>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…n#7686) Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…n#7686) Signed-off-by: Ryuta Kambe <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Ryuta Kambe <[email protected]>
knzo25
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 16, 2024
…n#7686) Signed-off-by: Ryuta Kambe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are fixes based on clang-tidy CRITICAL warnings ( = clang compile error)
For example,
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.