feat(centerpoint): cherrypicked upstream changes for x2_gen2/v0.29.0 #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utowarefoundation#6989) * feat: accelerated preprocessing for centerpoint Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: changed includes to quotes instead of brackets Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fixed variable name Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * fix: addressed the case where the points in the cache is over the maximum capacity Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * fix: fixed the offset of the output buffer in the kernel Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: reimplemented old logic in the pointpainting package since the new centerpoint logic is incompatible Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * fix: eigen matrices are column major by default. this commit fixes the code that assumed row-major, implements check for data layout, and updates tests Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: fixed missing virtual destructor Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Co-authored-by: kminoda <[email protected]>
…n#7686) Signed-off-by: Ryuta Kambe <[email protected]>
…ion#7758) Signed-off-by: Amadeusz Szymko <[email protected]>
fix: ml detector buffer capacity and parameterization (autowarefoundation#7936) * fix: increased the buffer capacity in ML-based detectors (1M -> 2M due to new models) but parameterized to users can adapt it to their use cases Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: added schema parts Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * chore: points are countable ! Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…ystem (autowarefoundation#8272) Signed-off-by: amadeuszsz <[email protected]> Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…on#8572) fix:unusedFunction Signed-off-by: kobayu858 <[email protected]>
…utowarefoundation#8731) add centerpoint sigma parameter Signed-off-by: yoshiri <[email protected]> Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
… to the model (autowarefoundation#8814) * feat: shuffling points before feeding them into the model to achieve uniform sampling into the voxels Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> * Update perception/autoware_lidar_centerpoint/src/node.cpp Co-authored-by: kminoda <[email protected]> * Update perception/autoware_lidar_centerpoint/src/node.cpp Co-authored-by: kminoda <[email protected]> * Update perception/autoware_lidar_centerpoint/lib/centerpoint_trt.cpp Co-authored-by: kminoda <[email protected]> * Update perception/autoware_lidar_centerpoint/include/autoware/lidar_centerpoint/centerpoint_config.hpp Co-authored-by: kminoda <[email protected]> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]> Co-authored-by: kminoda <[email protected]> Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…_t (autowarefoundation#8820) * refactor(autoware_lidar_centerpoint): use std::size_t instead of size_t Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…its definition (autowarefoundation#8980) * fix: convert object's velocity to follow its definition in box3DToDetectedObject function Signed-off-by: Taekjin LEE <[email protected]> * Update perception/autoware_lidar_centerpoint/lib/ros_utils.cpp Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…towarefoundation#8996) * fix(autoware_lidar_centerpoint): fix covariance converter considering the twist covariance matrix is based on the object coordinate Signed-off-by: Taekjin LEE <[email protected]> fix style * fix: update test of box3DToDetectedObject function Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…field (autowarefoundation#9471) Signed-off-by: kobayu858 <[email protected]>
… now I wil leave it as a default parameter Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
knzo25
requested review from
amadeuszsz,
scepter914,
kminoda,
badai-nguyen,
ktro2828,
miursh,
tzhong518 and
yukkysaito
as code owners
|
@YoshiRi |
|
@knzo25 |
YoshiRi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherrypicked improvements to centerpoint
List:
Does not include the autoware's namespace PR
The cherrypicks were done using
git cherry-pick HASHand not copied manually as proposed before.If done sequence, skipping the ones with breaking changes (autoware prefix), there were minimal conflicts
Related links
Parent Issue:
How was this PR tested?
Run https://console.data-search.tier4.jp/projects/x2_dev/environments/190ce3fb-2480-4710-a8db-b976814f90cb/rosbags/977d3e84-f61a-40d0-8629-7c01f7aa4700
and centerpoint seemed to be working ok
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.