Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_object_tracker)!: fix namespace and directory structure #7658

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jun 24, 2024

Description

This PR puts headers in the autoware namespace.
Part of: autowarefoundation/autoware#4569

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 1.22%. Comparing base (507e3f4) to head (23dc7fa).
Report is 166 commits behind head on main.

Files Patch % Lines
...racker/src/tracker/model/linear_motion_tracker.cpp 0.00% 31 Missing ⚠️
...racker/model/constant_turn_rate_motion_tracker.cpp 0.00% 22 Missing ⚠️
...r_object_tracker/src/radar_object_tracker_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7658       +/-   ##
==========================================
- Coverage   14.84%   1.22%   -13.63%     
==========================================
  Files        1999      77     -1922     
  Lines      139163    4405   -134758     
  Branches    43716     407    -43309     
==========================================
- Hits        20661      54    -20607     
+ Misses      95731    4330    -91401     
+ Partials    22771      21    -22750     
Flag Coverage Δ
differential 1.22% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin changed the title refactor(radar_object_tracker): namespace fix refactor(radar_object_tracker)!: fix namespace and directory structure Jun 25, 2024
Copy link

github-actions bot commented Jun 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review June 26, 2024 05:03
@technolojin technolojin enabled auto-merge (squash) June 27, 2024 06:43
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit efd1afc into autowarefoundation:main Jun 27, 2024
29 of 31 checks passed
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
autowarefoundation#7658)

* chore: refactor radar_object_tracker_node.cpp and related files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: remove MSG_COV_IDX enum in utils.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
autowarefoundation#7658)

* chore: refactor radar_object_tracker_node.cpp and related files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: remove MSG_COV_IDX enum in utils.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
autowarefoundation#7658)

* chore: refactor radar_object_tracker_node.cpp and related files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: remove MSG_COV_IDX enum in utils.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin deleted the refactor/namespace-radar_object_tracker branch July 22, 2024 09:39
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7658)

* chore: refactor radar_object_tracker_node.cpp and related files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: remove MSG_COV_IDX enum in utils.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: fix the node name

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for radar_object_tracker files

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants