Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_radar_object_tracker): move headers to src and rename package #7808

Closed
wants to merge 2 commits into from
Closed

refactor(autoware_radar_object_tracker): move headers to src and rename package #7808

wants to merge 2 commits into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 3, 2024

Description

move headers to src and rename package

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

@technolojin this PR is a followup to #7658 I moved the headers and renamed the package.

technolojin
technolojin requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. package renaming
    I am thinking to do it after all the other packages are ready.

  2. moving headers
    the association class will be replaced by shared library. mentioned in refactor(autoware_object_merger): move headers to src and rename package #7804 (review)

@esteve esteve mentioned this pull request Jul 4, 2024
Open
@esteve
Copy link
Contributor Author

esteve commented Jul 16, 2024

Closing as #7892 has already been merged.

@technolojin please have a look at the PR queue before submitting one that already does the same so as to not duplicate work. This PR was submitted before #7892 Thanks.

@esteve esteve closed this Jul 16, 2024
@esteve esteve deleted the fix-include-dir-autoware_radar_object_tracker branch July 16, 2024 13:08
@technolojin
Copy link
Contributor

@esteve
That was my mistake. I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technolojin technolojin technolojin requested changes

@scepter914 scepter914 Awaiting requested review from scepter914

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @technolojin