Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_object_merger): add test #7637

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jun 24, 2024

Description

Add pub/sub based test for simple_object_merger.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jun 24, 2024
@kminoda kminoda changed the title Feat/simple object merger/add test feat(simple_object_merger): add test Jun 24, 2024
kminoda added 2 commits June 24, 2024 22:03
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
@kminoda kminoda marked this pull request as ready for review June 24, 2024 13:42
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 24, 2024
@kminoda kminoda marked this pull request as draft June 24, 2024 13:43
Signed-off-by: kminoda <[email protected]>
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 7.03%. Comparing base (3d849e9) to head (6dac4fb).
Report is 1654 commits behind head on main.

Files with missing lines Patch % Lines
...ect_merger/test/test_simple_object_merger_node.cpp 97.18% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7637       +/-   ##
==========================================
- Coverage   15.09%   7.03%    -8.07%     
==========================================
  Files        1967      51     -1916     
  Lines      135941    2332   -133609     
  Branches    42122     191    -41931     
==========================================
- Hits        20520     164    -20356     
+ Misses      92700    2157    -90543     
+ Partials    22721      11    -22710     
Flag Coverage Δ
differential 7.03% <97.18%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Oct 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants